Update front.html.twig Add border to non federated notifications for admins and moderators #1297
Conversation
Add border to non federated notifications for admins and moderators This allows admins/moderators (when they receive notifications in the future) to quickly see if there has been any activity by local users on their instance
melroy89
added
enhancement
|
I'm not so sure about this change. Not that I'm not in favor to make it clear whether it's federated or non-federated notification. It's more about how to solve this issue. I believe adding a border would only add confusing. Only you now know what this means, but its not clear at all what a border means around a notification at all. If you would try to distinguish between local or federated messages. I believe we should solve it differently. Maybe with an icon + alt text or something, not a "random" border. |
I can add an alt text, that's a great idea. I've been using this for a while now and it works really well for me. The border is subtle but still catches my attention. I think it works better than an icon, I know from experience icons can be missed when skimming lists. These borders are hard to miss |
…r-admins-and-moderators
|
Added tooltip with username. Don't remember who but someone said it would be nice to be able to see which instance something was posted from. 2 birds with one stone. I don't feel this should be iconified. (Ignore the 'comment' it's for testing purposes) |
Title shows entry as local and author
| </div> | ||
|
|
||
| {% for notification in notifications %} | ||
| <div class="{{ html_classes('section section--small notification', {'opacity-50': notification.status is not same as 'new' }) }}"> | ||
| <div class="{{ html_classes('section section--small notification', {'opacity-50': notification.status is not same as 'new' }) }}" | ||
| {% if not notification.entry.magazine.apId and not notification.post.magazine.apId and (app.user.admin or app.user.moderator) %} |
There was a problem hiding this comment.
did you also tested on if the variable is not-set / null or empty?? And if these checks are not causing any 503 errors?
(eg. when you are not an admin or something like that)
There was a problem hiding this comment.
Yes I tested the lot and it's live on my instance, the variables are always set, which surprised me. Check me in mbin development as there is one weird situation with comments
There was a problem hiding this comment.
Yes I tested the lot and it's live on my instance, the variables are always set, which surprised me.
Well, because you are an admin? Try to login with a regular account?
There was a problem hiding this comment.
Yes I tested the lot and it's live on my instance, the variables are always set, which surprised me.
Well, because you are an admin? Try to login with a regular account?
I did, and if the user is not an admin they never reach the code. I'm stil looking at moderators, it is not working as I had hoped.
I always test everything with a regular account after updates and when changing things
Add border to non federated notifications for admins and moderators
This allows admins/moderators (when they receive notifications in the future) to quickly see if there has been any activity by local users on their instance