Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default local domain for entries #1280

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

BentiGorlich
Copy link
Member

When an entry is created it will be assigned a domain depending on its url. If it does not have one it previously fell back to the local domain. This commit removes this fallback as it can introduce long-running queries, when calculating the new number of entries in the domain

Also added a command to remove all remote entries from this local domain (not a migration as we don't know which id the local domain has).

What this looked like on Gehirneimer: there were >50,000 entries assigned to the domain gehirneimer.de. After removing the remote one it is down to 67. The problem with having this fallback is that you have to recount the number of entries in the domain. That could have been solved by just counting +1 instead of running a query (maybe in the future). The query for counting these entries took ~1.7 seconds, which is not terribly long, but it is avoidable and the domain should actually match the entry. No idea why the fallback was introduced

When an entry is created it will be assigned a domain depending on its url. If it does not have one it previously fell back to the local domain. This commit removes this fallback as it can introduce long-running queries, when calculating the new number of entries in the domain

Also added a command to remove all remote entries from this local domain (not a migration as we don't know which id the local domain has)
@BentiGorlich BentiGorlich added the backend Backend related issues and pull requests label Dec 10, 2024
@BentiGorlich BentiGorlich added this to the v1.7.4 milestone Dec 10, 2024
@BentiGorlich BentiGorlich self-assigned this Dec 10, 2024
Copy link
Member

@melroy89 melroy89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the docs? Maybe after PR is merged: #1274

@BentiGorlich
Copy link
Member Author

will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants