Remove deprecated use of count as positional arg #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-elliott-arm
added
enhancement
gilles-peskine-arm
requested changes
Oct 25, 2024
scripts/generate_test_code.py
Outdated
| @@ -762,7 +762,7 @@ def escaped_split(inp_str, split_char): | |||
| raise ValueError('Expected split character. Found string!') | |||
| out = re.sub(r'(\\.)|' + split_char, | |||
| lambda m: m.group(1) or '\n', inp_str, | |||
| len(inp_str)).split('\n') | |||
| count = len(inp_str)).split('\n') | |||
There was a problem hiding this comment.
Suggested change
| count = len(inp_str)).split('\n') | |
| count=len(inp_str)).split('\n') |
otherwise pylint will complain
There was a problem hiding this comment.
Until we have a CI in the framework repository, please at least run directly relevant tests. Here, at least check-python-files.sh (in a CI-like venv), and make tests.
gilles-peskine-arm
added
needs-work
and removed
needs-review
Python 13 requires count to be passed as a kwarg rather than a positional arg because of potential confusion with flags, see python/cpython#56166 Signed-off-by: Paul Elliott <[email protected]>
paul-elliott-arm
force-pushed
the
remove_re_sub_count_positional_arg
branch
from
03b11fb to
59ec32a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No intended change in functionality. Just removing the deprecated warning I am getting every time I generate test code.
Python 13 requires count to be passed as a kwarg rather than a positional arg because of potential confusion with flags, see python/cpython#56166