Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to search the outcome file for configurations with given requirements #20

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gilles-peskine-arm
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm commented May 28, 2024

Resolves Mbed-TLS/mbedtls#9195

To try it out, grab an outcome file from a nightly.

Testing: I ran pylint and mypy manually. There is no corresponding PR in the main repo because nothing in the main repo depends on it, this is an entry-point script intended for use by maintainers.

If the outcome file format or the test_suite_config test case descriptions
change, this should be detected by the unit tests here.

Signed-off-by: Gilles Peskine <[email protected]>
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) needs-preceding-pr Requires another PR to be merged first and removed needs-work labels May 29, 2024
yanesca
yanesca previously approved these changes Aug 5, 2024
Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the script locally and it works correctly. The source looks good to me.

scripts/search_outcomes_config.py Outdated Show resolved Hide resolved
@gilles-peskine-arm gilles-peskine-arm removed the request for review from paul-elliott-arm August 5, 2024 16:16
Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-preceding-pr Requires another PR to be merged first needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Projects
Status: In Development
Development

Successfully merging this pull request may close these issues.

Configuration test coverage search tool
2 participants