-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script to search the outcome file for configurations with given requirements #20
Open
gilles-peskine-arm
wants to merge
3
commits into
Mbed-TLS:main
Choose a base branch
from
gilles-peskine-arm:search_outcomes_config-create
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Script to search the outcome file for configurations with given requirements #20
gilles-peskine-arm
wants to merge
3
commits into
Mbed-TLS:main
from
gilles-peskine-arm:search_outcomes_config-create
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rements Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
needs-work
priority-high
High priority - will be reviewed soon
labels
May 28, 2024
If the outcome file format or the test_suite_config test case descriptions change, this should be detected by the unit tests here. Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
needs-review
Every commit must be reviewed by at least two team members,
needs-reviewer
This PR needs someone to pick it up for review
size-s
Estimated task size: small (~2d)
needs-preceding-pr
Requires another PR to be merged first
and removed
needs-work
labels
May 29, 2024
4 tasks
yanesca
previously approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the script locally and it works correctly. The source looks good to me.
Signed-off-by: Gilles Peskine <[email protected]>
yanesca
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-preceding-pr
Requires another PR to be merged first
needs-review
Every commit must be reviewed by at least two team members,
needs-reviewer
This PR needs someone to pick it up for review
priority-high
High priority - will be reviewed soon
size-s
Estimated task size: small (~2d)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Mbed-TLS/mbedtls#9195
To try it out, grab an outcome file from a nightly.
Testing: I ran
pylint
andmypy
manually. There is no corresponding PR in the main repo because nothing in the main repo depends on it, this is an entry-point script intended for use by maintainers.