Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: await uncaught promises in tests #582

Merged
merged 1 commit into from
Dec 20, 2024
Merged

chore: await uncaught promises in tests #582

merged 1 commit into from
Dec 20, 2024

Conversation

basmasking
Copy link
Member

Fixes #581

Changes proposed in this pull request:

  • Vitest 3 is going to change the way unhandled promises are handled, these should be awaited by us. The warning is already present in Vitest 2, so better be prepared.

@MaskingTechnology/jitar

@basmasking basmasking linked an issue Dec 20, 2024 that may be closed by this pull request
Prepare tests for vitest 3 #581
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@petermasking petermasking merged commit 95f87ba into main Dec 20, 2024
5 checks passed
@petermasking petermasking deleted the 581-prepare-tests-for-vitest-3 branch December 20, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petermasking petermasking petermasking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepare tests for vitest 3
2 participants
@basmasking @petermasking