Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slack): add /critical shortcut to create incident more efficiently #117

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jennafauconnier
Copy link
Collaborator

@jennafauconnier jennafauconnier commented Nov 8, 2024

Add Critical Incident Modal for Emergency Responses

Description

This pull request introduces a new feature that allows users to quickly create critical incidents using the /incident critical command. This streamlined process requires users to fill in only the title, description, component, priority and environment, significantly reducing the time needed to report emergencies.

Changes Made

  • Implemented the /incident critical command for creating critical incidents.
  • Created a modal form that requires only essential fields: title, description, component, and priority.
  • Restricted the feature to "advanced users" (users in an incident response group/on-call).

Motivation and Context

This change is important as it addresses the need for a more efficient way to report critical incidents during emergency situations. By simplifying the reporting process, we ensure that users can quickly communicate essential information, facilitating faster responses.

How to Test

  1. Ensure you are a member of the incident response group/on-call team.
  2. In Slack, use the command /incident critical.
  3. Fill in the title, description, component, and priority fields.
  4. Submit the form and verify that the incident is created successfully in the system.
  5. Check logs for any errors and ensure the incident appears in the incident management system.

Checklist

  • I have tested my changes
  • My code follows the style guidelines of this project

@jennafauconnier jennafauconnier changed the title Add Critical Incident Modal for Emergency Responses feat(slack): add /critical shortcut to create incident more efficiently Nov 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 52.27273% with 21 lines in your changes missing coverage. Please review.

Project coverage is 62.78%. Comparing base (60a7836) to head (2cb44cc).

Files with missing lines Patch % Lines
src/firefighter/slack/views/modals/critical.py 57.89% 16 Missing ⚠️
src/firefighter/incidents/forms/create_incident.py 0.00% 3 Missing ⚠️
src/firefighter/slack/views/events/commands.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   62.83%   62.78%   -0.05%     
==========================================
  Files         215      216       +1     
  Lines        9587     9629      +42     
  Branches     1289     1294       +5     
==========================================
+ Hits         6024     6046      +22     
- Misses       3354     3374      +20     
  Partials      209      209              
Flag Coverage Δ
unittests 62.78% <52.27%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants