-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(slack): advertise when others are creating an incident #115
base: main
Are you sure you want to change the base?
Conversation
…nd a message to signal that's someone is creating an incident
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
==========================================
- Coverage 62.83% 62.75% -0.08%
==========================================
Files 215 215
Lines 9587 9613 +26
Branches 1289 1289
==========================================
+ Hits 6024 6033 +9
- Misses 3354 3371 +17
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -37,13 +38,15 @@ | |||
@receiver(signal=create_incident_conversation) | |||
def create_incident_slack_conversation( | |||
incident: Incident, | |||
source_channel: IncidentChannel, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In trigger_incident_workflow
, it's Any
, so we need to check that it's an IncidentChannel
, and probably accept None by default.
Implement Notifications for Incident Opening and Creation Links in Slack
Description
This PR introduces two new message classes for handling notifications related to incident management in the Slack application. The first class provides a warning when a user is in the process of opening an incident, while the second class informs users when a new incident has been created.
Changes Made
✅ Created SlackMessageIncidentOpeningWarning to notify users when an incident is being opened.
✅ Created SlackMessageIncidentCreationRedirection to inform users of a new incident creation.
✅ Updated IDs for both classes to ensure they are distinct and descriptive.
Motivation and Context
These changes are important to improve user experience by preventing multiple incident creations and guiding users to newly created incidents. By providing timely notifications, we can enhance communication and efficiency within the team.
How to Test
Checklist