Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update themes.md #4680

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update themes.md #4680

wants to merge 1 commit into from

Conversation

Luluser
Copy link

@Luluser Luluser commented Dec 18, 2024

Description

Fixes #4679

Add description to theme a LScene and how to access all the attributes of the Axis3D, Should be useful to the users that want to theme further than the simple example given but also for users willingly to modify an attribute after plotting without theming.

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

Add description to theme a LScene and how to access all the attributes of the Axis3D, 
Should be useful to the users that want to theme further than the simple example given but also for users willingly to modify an attribute after plotting without theming.
Copy link
Member

@asinghvi17 asinghvi17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!! Couple of minor comments but otherwise looks good.


An exhaustive collection of the axis attribute can be found with :

LScene(Figure()).scene[OldAxis].attributes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?axis3d is probably better to point to here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes my bad I tried ?Axis3D instead of ?axis3d. Also I thought it would be useful to put the OldAxis thing in the documentation but that's probably another issue/PR.

@@ -130,6 +130,22 @@ ggplot_theme = Theme(
with_theme(example_plot, ggplot_theme)
```

LScene blocks can be themed through an Axis3D block theme.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lscene blocks can be themed by setting the theme for the Axis3D recipe (note: not the Axis3 block) that plots the LScrene axis.

Copy link
Member

@asinghvi17 asinghvi17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!! Couple of minor comments but otherwise looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Work in progress
Development

Successfully merging this pull request may close these issues.

Theme example for LScene in the documentation
2 participants