Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set start point of selection of avg-block-time 1% #137

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

Keith-CY
Copy link
Member

@Keith-CY Keith-CY commented Nov 4, 2023

Selection starts from 1% because the avg block time is extremely high on blockchain launch

Ref: nervosnetwork#1350

Selection starts from 1% because the avg block time is
extremely high on blockchain launch

Ref: nervosnetwork#1350
Copy link

vercel bot commented Nov 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 6:45am

@Keith-CY
Copy link
Member Author

Keith-CY commented Nov 4, 2023

BTW, I found the range of y-axis doesn't adjust itself along with moving the x-axis selection, possibly due to being frozen Magickbase/ckb-explorer-public-issues#461 (comment)

Remove the fixed range so the y-scale adjust itself automatically
by scaling
@Keith-CY
Copy link
Member Author

Keith-CY commented Nov 4, 2023

BTW, I found the range of y-axis doesn't adjust itself along with moving the x-axis selection, possibly due to being frozen Magickbase/ckb-explorer-public-issues#461 (comment)

The y-axis doesn't scale because its range is set manually, fixed by 231e972

@WhiteMinds
Copy link

I think this might not be as expected:

origin:

image

after 231e972

image

Copy link

@WhiteMinds WhiteMinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to Confirm.

@Keith-CY
Copy link
Member Author

Keith-CY commented Nov 7, 2023

I think this might not be as expected:

origin:

image

after 231e972

image

The preview is

I think this might not be as expected:

origin:

image

after 231e972

image

The charts are slightly different at the left end

image

And I can see the selection is updated
image

@WhiteMinds
Copy link

And I can see the selection is updated

I dragged them into the same range, which means the data displayed should be consistent.

@Keith-CY
Copy link
Member Author

Keith-CY commented Nov 7, 2023

And I can see the selection is updated

I dragged them into the same range, which means the data displayed should be consistent.

It's probably caused by being frozen if the chart is not updated during expanding the selection, which should be solved by #138

@WhiteMinds
Copy link

I avoided the part where the tooltip error caused the table to freeze.

Recording.2023-11-07.144429.mp4

@Keith-CY
Copy link
Member Author

Keith-CY commented Nov 7, 2023

I avoided the part where the tooltip error caused the table to freeze.

Recording.2023-11-07.144429.mp4

The range of the weekly moving avg is auto-adjusted, so the ranges are different

Copy link

@WhiteMinds WhiteMinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The range of the weekly moving avg is auto-adjusted, so the ranges are different

If this is as expected, then there is no problem.

@Keith-CY
Copy link
Member Author

Keith-CY commented Nov 7, 2023

The range of the weekly moving avg is auto-adjusted, so the ranges are different

If this is as expected, then there is no problem.

The chart is hard to read even being scaled when range auto-adjustment is not enabled. And this PR is to move outliers out by default, so the fluctuation of trending can be clear. So I removed the fixed min and max

@Keith-CY Keith-CY merged commit a2a22de into develop Nov 7, 2023
5 checks passed
@Keith-CY Keith-CY deleted the offset-start-point-of-chart branch November 7, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants