-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set start point of selection of avg-block-time 1% #137
Conversation
Selection starts from 1% because the avg block time is extremely high on blockchain launch Ref: nervosnetwork#1350
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BTW, I found the range of y-axis doesn't adjust itself along with moving the x-axis selection, possibly due to being frozen Magickbase/ckb-explorer-public-issues#461 (comment) |
Remove the fixed range so the y-scale adjust itself automatically by scaling
The y-axis doesn't scale because its range is set manually, fixed by 231e972 |
I think this might not be as expected: origin: after 231e972 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to Confirm.
I dragged them into the same range, which means the data displayed should be consistent. |
It's probably caused by being frozen if the chart is not updated during expanding the selection, which should be solved by #138 |
I avoided the part where the tooltip error caused the table to freeze. Recording.2023-11-07.144429.mp4 |
The range of the weekly moving avg is auto-adjusted, so the ranges are different |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The range of the weekly moving avg is auto-adjusted, so the ranges are different
If this is as expected, then there is no problem.
The chart is hard to read even being scaled when range auto-adjustment is not enabled. And this PR is to move outliers out by default, so the fluctuation of trending can be clear. So I removed the fixed |
Selection starts from 1% because the avg block time is extremely high on blockchain launch
Ref: nervosnetwork#1350