[CodeForPoznan#121] Added validation of postCode

Maciek246 · Feb 17, 2020 · cac2bd3 · cac2bd3
1 parent d07986f
commit cac2bd3
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 7 deletions.
diff --git a/src/db/models/school.js b/src/db/models/school.js
@@ -22,7 +22,13 @@ const School = sequelize.define(
     },
     postCode: {
       type: Sequelize.STRING(6),
-      allowNull: false
+      allowNull: false,
+      validate: {
+        isValidaPolishPostCode(value) {
+          const regex = /^[0-9]{2}-[0-9]{3}$/;
+          if (!regex.test(value)) throw new Error("Invalid polish postal code");
+        }
+      }
     },
     postOffice: {
       type: Sequelize.STRING(80),

diff --git a/src/test/models/school_model.test.js b/src/test/models/school_model.test.js
@@ -5,7 +5,7 @@ const { schoolData } = require("../factories/schoolFactory");
 const { School } = require("../../db/models");
 
 describe("School model", () => {
-  beforeAll(() => {
+  beforeEach(() => {
     return sequelize
       .sync({ force: true })
       .then(() => schoolTypeFactory("mock"));
@@ -22,11 +22,20 @@ describe("School model", () => {
     expect(school.name).toEqual("TEST");
   });
 
-  // it("should validate `postCode`", () => {
-  //   const school = await sequelize
-  //   .sync({ force: true })
-  //   .then(() => schoolFactory({ name: "TEST", type: "przedszkole" }));
-  // })
+  it("should validate `postCode`", async () => {
+    const school = await sequelize
+      .sync({ force: true })
+      .then(() =>
+        schoolFactory({
+          type: "mock",
+          postCode: "invalid code",
+          SchoolTypeName: "mock"
+        })
+      )
+      .catch(err => err.message);
+
+    expect(school).toEqual("Validation error: Invalid polish postal code");
+  });
 
   describe("has virtual methods which", () => {
     it("return concatenated address data by calling `address`", async () => {