Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky voucher redemption Cypress test #726

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

Splines
Copy link
Member

@Splines Splines commented Dec 9, 2024

I was able to reproduce a flaky Cypress test locally. Fixed by adding cy.then(() => {...}); statements after logging out, then logging in again as a new user. I also intercept a POST request now to make sure the deletion of the account is finished before we continue.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.27%. Comparing base (6382fb5) to head (1d80266).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #726      +/-   ##
==========================================
- Coverage   54.28%   54.27%   -0.02%     
==========================================
  Files         170      170              
  Lines        7346     7346              
==========================================
- Hits         3988     3987       -1     
- Misses       3358     3359       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fosterfarrell9 fosterfarrell9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Splines Splines merged commit a53ef17 into dev Dec 9, 2024
4 checks passed
@Splines Splines deleted the fix/flaky-cypress-again branch December 9, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants