Fix flaky user deletion & redemption cypress test #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually `click()` should already do this for us I thought.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #718 +/- ##
======================================
Coverage ? 54.30%
======================================
Files ? 170
Lines ? 7348
Branches ? 0
======================================
Hits ? 3990
Misses ? 3358
Partials ? 0 ☔ View full report in Codecov by Sentry. |
This was referenced Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cypress docs on Actionability state that
.click()will wait until the element reaches an "actionable state". This includes a check that the element is not hidden. However, in our tests we see that after visiting a page, a button is deemed "visible" even though it's not visible in the viewport yet.Here we fix this flaky test. If this kind of behavior occurs more offen, either we use Cypress in a wrong manner or Cypress has a bug. In both cases it might be worth to consider overriding the
.click()event by a custom method that calls.should("be.visible").click()instead, but this is something for a future PR (maybe).