Fix unknown user variable after deletion #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #717 +/- ##
==========================================
+ Coverage 53.80% 53.82% +0.01%
==========================================
Files 157 157
Lines 6644 6649 +5
==========================================
+ Hits 3575 3579 +4
- Misses 3069 3070 +1 ☔ View full report in Codecov by Sentry. |
Splines
added a commit
that referenced
this pull request
Dec 8, 2024
* Set retry option to false for UserCleanerJob (#715) * Deal with registration edge cases in UserCleaner (#693) (#716) * Deal with registration edge cases in UserCleaner * Replace `last_sign_in_at` by `current_sign_in_at` * Simplify inactive_users method via usage of scopes * Add another scope for recently active users * Fix unknown user variable after deletion (#717) * Fix unknown user variable after deletion * Adjust other occurrence of method * Update failing user cleaner jobs with new method signature * Expect user email for deletion mail * Fix `with` syntax --------- Co-authored-by: fosterfarrell9 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the user cleaner, we delete users that haven't logged in for too long. Before the deletion, we enqueue a last mail to the user to verify that their account was deleted. This mail might be sent after we have actually deleted the user. The user object is passed as reference to the mail handler and is therefore not available anymore after the user was deleted. Hence, the delivery of the mail fails. This PR addresses this by passing the respective user email and locale by value and not by reference.