Deal with registration edge cases in UserCleaner (cherry-pick #693) #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Deal with registration edge cases in UserCleaner * Replace `last_sign_in_at` by `current_sign_in_at` * Simplify inactive_users method via usage of scopes * Add another scope for recently active users
Splines
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
==========================================
+ Coverage 53.80% 53.85% +0.04%
==========================================
Files 157 157
Lines 6644 6651 +7
==========================================
+ Hits 3575 3582 +7
Misses 3069 3069 ☔ View full report in Codecov by Sentry. |
fosterfarrell9
approved these changes
Nov 27, 2024
Splines
added a commit
that referenced
this pull request
Dec 8, 2024
* Set retry option to false for UserCleanerJob (#715) * Deal with registration edge cases in UserCleaner (#693) (#716) * Deal with registration edge cases in UserCleaner * Replace `last_sign_in_at` by `current_sign_in_at` * Simplify inactive_users method via usage of scopes * Add another scope for recently active users * Fix unknown user variable after deletion (#717) * Fix unknown user variable after deletion * Adjust other occurrence of method * Update failing user cleaner jobs with new method signature * Expect user email for deletion mail * Fix `with` syntax --------- Co-authored-by: fosterfarrell9 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already merged #693 in
dev, but not inmain. Due to the situation described in Release1.14.2, we should get this one into production as quickly as possible.Therefore, I've cherrypicked the merge commit to this new branch that we can directly merge into
main.Deal with registration edge cases in UserCleaner
Replace
last_sign_in_atbycurrent_sign_in_atSimplify inactive_users method via usage of scopes
Add another scope for recently active users