-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RuboCop & fix offenses by new lints #714
Conversation
@fosterfarrell9 Could you maybe look into the To tackle the offenses, we'd have to know exactly which attributes are guaranteed to be non-null. |
I do not think this lint is useful. Rewriting this would make it unnecessarily bloated. Also, for the second one, we would have to dig into thredded. I suggest raising the maximum value to 4. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #714 +/- ##
======================================
Coverage ? 54.30%
======================================
Files ? 170
Lines ? 7348
Branches ? 0
======================================
Hits ? 3990
Misses ? 3358
Partials ? 0 ☔ View full report in Codecov by Sentry. |
We update RuboCop and fix problems caused by the new lints that were introduced.