Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RuboCop & fix offenses by new lints #714

Merged
merged 5 commits into from
Dec 1, 2024
Merged

Conversation

Splines
Copy link
Member

@Splines Splines commented Nov 24, 2024

We update RuboCop and fix problems caused by the new lints that were introduced.

@Splines Splines added the dependencies Pull requests that update a dependency file label Nov 24, 2024
@Splines Splines self-assigned this Nov 24, 2024
@Splines
Copy link
Member Author

Splines commented Nov 24, 2024

@fosterfarrell9 Could you maybe look into the Style/SafeNavigationChainLength? I've adjusted the maximum value to 3 (default was 2) and we still have two offenses. We might want to reset the max value to 2, however I'm not too sure yet how to tackle the respective offenses. If we don't think this lint is useful, we could also disable it entirely.

To tackle the offenses, we'd have to know exactly which attributes are guaranteed to be non-null.

@Splines Splines changed the title Deps/rubocop update Update RuboCop & fix offenses by new lints Nov 24, 2024
@Splines Splines mentioned this pull request Nov 24, 2024
@fosterfarrell9
Copy link
Collaborator

I do not think this lint is useful. Rewriting this would make it unnecessarily bloated. Also, for the second one, we would have to dig into thredded. I suggest raising the maximum value to 4.

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev@7dd3a33). Learn more about missing BASE report.

Files with missing lines Patch % Lines
app/helpers/submissions_helper.rb 0.00% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #714   +/-   ##
======================================
  Coverage       ?   54.30%           
======================================
  Files          ?      170           
  Lines          ?     7348           
  Branches       ?        0           
======================================
  Hits           ?     3990           
  Misses         ?     3358           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Splines Splines merged commit e97ec8a into dev Dec 1, 2024
6 of 8 checks passed
@Splines Splines deleted the deps/rubocop-update branch December 1, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants