#patch (2295) Ajouter une colonne indiquant si une action financée RB est présente #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment.
Possibilité de créer un type spécifique qui serait utilisé dans Action.d.ts et Shantytown.d.ts:
export type FinancedShantytownAction = {
shantytown_id?: number,
hasAtLeastOneActionFinanced: boolean,
};
|
|
||
| const clauseGroup = where().can(user).do('read', 'action'); | ||
| const passedYear = moment(date).format('YYYY'); | ||
| const townsWithFinancedActions = await actionModel.fetchFinancedActionsByYear(null, parseInt(passedYear, 10), clauseGroup); |
There was a problem hiding this comment.
Type ActionSelectRow[]?
| const clauseGroup = where().can(user).do('read', 'action'); | ||
| const passedYear = moment(date).format('YYYY'); | ||
| const townsWithFinancedActions = await actionModel.fetchFinancedActionsByYear(null, parseInt(passedYear, 10), clauseGroup); | ||
| const transformedShantytowns = enrichShantytown(townsWithFinancedActions); |
There was a problem hiding this comment.
Type FinancedShantytownAction[]?
|
|
||
| const clauseGroup = where().can(user).do('read', 'action'); | ||
| const currentYear = moment(new Date()).format('YYYY'); | ||
| const townsWithFinancedActions = await actionModel.fetchFinancedActionsByYear(null, parseInt(currentYear, 10), clauseGroup); |
There was a problem hiding this comment.
Type ActionSelectRow[]?
| const clauseGroup = where().can(user).do('read', 'action'); | ||
| const currentYear = moment(new Date()).format('YYYY'); | ||
| const townsWithFinancedActions = await actionModel.fetchFinancedActionsByYear(null, parseInt(currentYear, 10), clauseGroup); | ||
| const transformedShantytowns = enrichShantytown(townsWithFinancedActions); |
There was a problem hiding this comment.
Type FinancedShantytownAction[]?
| @@ -0,0 +1,20 @@ | |||
| import { ActionSelectRow } from '#server/models/actionModel/fetchByShantytown/fetchFinancedActionsByYear'; | |||
|
|
|||
| type FinancedShantytownAction = { | |||
There was a problem hiding this comment.
Pourrait être sorti dans un fichier de typage à lui tout seul, appelé ici et dans Shantytown.d.ts et Action.d.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧾 Ticket Trello
https://trello.com/c/SVMFGvge/XXX
🛠 Description de la PR
🚨 Notes pour la mise en production