review: remove useless function and replace null from properties by u…

…ndefined

frontend/src/domain/entities/AMPs.ts

@@ -6,9 +6,9 @@ export type AMPFromAPI = {
   geom: GeoJSON.MultiPolygon
   id: number
   name: string
-  ref_reg: string | null
-  type: string | null
-  url_legicem: string | null
+  ref_reg: string | undefined
+  type: string | undefined
+  url_legicem: string | undefined
 }
 export type AMP = AMPFromAPI & { bbox: Extent }
 

frontend/src/domain/entities/layers/index.ts

@@ -6,16 +6,6 @@ import type { GeoJSON as GeoJSONType } from '../../types/GeoJSON'
 import type { MultiPoint, Point, MultiPolygon, Polygon } from 'ol/geom'
 import type Geometry from 'ol/geom/Geometry'
 
-/**
- *
- * @param {Object} layer
- * @param { String } layer.type
- * @param { String | null } layer.topic
- * @param { String | null } layer.zone
- * @returns String
- */
-export const getLayerNameNormalized = layer => [layer.type, layer.topic, layer.zone].filter(Boolean).join(':')
-
 export function convertToGeoJSONGeometryObject(feature: Geometry): GeoJSONType.Geometry {
   const format = new GeoJSON()
 

frontend/src/domain/entities/layers/utils.ts

@@ -5,7 +5,7 @@ import type { VigilanceArea } from '@features/VigilanceArea/types'
 import type { AMPProperties } from 'domain/entities/AMPs'
 import type { RegulatoryLayerCompactProperties } from 'domain/entities/regulatory'
 
-export const getTitle = (name?: string | undefined | null) => (name ? `${name?.replace(/[_]/g, ' ')}` : '')
+export const getTitle = (name?: string | undefined) => (name ? `${name?.replace(/[_]/g, ' ')}` : '')
 
 type GenericLayerType = AMPProperties | RegulatoryLayerCompactProperties | VigilanceArea.VigilanceAreaProperties
 

frontend/src/domain/entities/semaphore.ts

@@ -1,15 +1,15 @@
 import type { InteractionType } from './map/constants'
 
 export type Semaphore = {
-  administration: string | undefined | null
-  base: string | undefined | null
-  department: string | undefined | null
-  email: string | undefined | null
-  facade: string | undefined | null
+  administration: string | undefined
+  base: string | undefined
+  department: string | undefined
+  email: string | undefined
+  facade: string | undefined
   geom: { coordinates: number[]; type: InteractionType.POINT }
   id: number
   name: string
-  phoneNumber: string | undefined | null
-  unit: string | undefined | null
-  url: string | undefined | null
+  phoneNumber: string | undefined
+  unit: string | undefined
+  url: string | undefined
 }

frontend/src/domain/types/layer.ts

@@ -1,14 +1,6 @@
 import type VectorLayer from 'ol/layer/Vector'
 import type VectorSource from 'ol/source/Vector'
 
-export type AdministrativeOrRegulatoryLayerIdentity = {
-  id: string
-  namespace: string
-  topic: string | null
-  type: string
-  zone: string | null
-}
-
 export type LayerToFeatures = {
   area: number
   center: number[]

frontend/src/features/Dashboard/components/DashboardForm/Amps/ListLayerGroup.tsx

@@ -55,7 +55,7 @@ export function ListLayerGroup({ groupName, isSelected = false, layerIds, select
           data-cy={`dashboard-${isSelected ? 'selected-' : ''}amp-result-group`}
           title={groupName}
         >
-          {getTitle(groupName) ?? ''}
+          {getTitle(groupName)}
         </LayerSelector.GroupName>
         <LayerSelector.IconGroup>
           <LayerSelector.ZonesNumber>{`${layerIds.length}/${totalNumberOfZones}`}</LayerSelector.ZonesNumber>

frontend/src/features/Dashboard/components/DashboardForm/RegulatoryAreas/ListLayerGroup.tsx

@@ -59,7 +59,7 @@ export function ListLayerGroup({
           data-cy={`dashboard-${isSelected ? 'selected-' : ''}regulatory-result-group`}
           title={groupName}
         >
-          {getTitle(groupName) ?? ''}
+          {getTitle(groupName)}
         </LayerSelector.GroupName>
         <LayerSelector.IconGroup>
           <LayerSelector.ZonesNumber>{`${layerIds.length}/${totalNumberOfZones}`}</LayerSelector.ZonesNumber>

frontend/src/features/InterestPoint/slice.ts

@@ -12,7 +12,7 @@ export interface InterestPointState {
   isEditing: boolean
 }
 
-const newInterestPoint = () => ({ coordinates: null, name: null, observations: null, uuid: uuidv4() })
+const newInterestPoint = () => ({ coordinates: undefined, name: undefined, observations: undefined, uuid: uuidv4() })
 
 const INITIAL_STATE: InterestPointState = {
   currentInterestPoint: newInterestPoint(),

frontend/src/features/InterestPoint/types.ts

@@ -13,10 +13,10 @@ export type InterestPoint = {
 }
 
 export type NewInterestPoint = {
-  coordinates: Coordinate | null
+  coordinates: Coordinate | undefined
   feature?: Feature<LineString>
-  name: string | null
-  observations: string | null
+  name: string | undefined
+  observations: string | undefined
   uuid: string
 }
 

frontend/src/features/InterestPoint/useCases/updateName.ts

@@ -7,10 +7,8 @@ export const updateNameAction =
     const { currentInterestPoint }: InterestPointState = getState().interestPoint
 
     if (currentInterestPoint?.name !== name) {
-      const updatedName = name === undefined ? null : name
-
       const { name: currentName, ...currentInterestPointWithoutName } = currentInterestPoint
 
-      dispatch(updateCurrentInterestPoint({ name: updatedName, ...currentInterestPointWithoutName }))
+      dispatch(updateCurrentInterestPoint({ name, ...currentInterestPointWithoutName }))
     }
   }

frontend/src/features/InterestPoint/useCases/updateObservations.ts

@@ -7,11 +7,8 @@ export const updateObservationsAction =
     const { currentInterestPoint }: InterestPointState = getState().interestPoint
 
     if (currentInterestPoint?.observations !== observations) {
-      const updatedObservations = observations === undefined ? null : observations
       const { observations: currentObservations, ...currentInterestPointWithoutObservations } = currentInterestPoint
 
-      dispatch(
-        updateCurrentInterestPoint({ observations: updatedObservations, ...currentInterestPointWithoutObservations })
-      )
+      dispatch(updateCurrentInterestPoint({ observations, ...currentInterestPointWithoutObservations }))
     }
   }

frontend/src/features/layersSelector/myAmps/MyAMPLayerZone.tsx

@@ -16,7 +16,7 @@ export function MyAMPLayerZone({ amp, isDisplayed }: { amp: AMP; isDisplayed: bo
 
   const handleRemoveZone = () => dispatch(removeAmpZonesFromMyLayers([amp.id]))
 
-  const displayedName = getTitle(amp?.type) ?? 'AUNCUN NOM'
+  const displayedName = getTitle(amp?.type) || 'AUCUN NOM'
 
   const toggleAmpZoneMetadata = () => {
     if (metadataIsShown) {

frontend/src/features/layersSelector/myRegulatoryLayers/MyRegulatoryLayerZone.tsx

@@ -28,7 +28,7 @@ export function RegulatoryLayerZone({ regulatoryZone }: RegulatoryLayerZoneProps
 
   const handleRemoveZone = () => dispatch(removeRegulatoryZonesFromMyLayers([regulatoryZone.id]))
 
-  const displayedName = getTitle(regulatoryZone?.entity_name) ?? 'AUNCUN NOM'
+  const displayedName = getTitle(regulatoryZone?.entity_name) || 'AUCUN NOM'
 
   const toggleRegulatoryZoneMetadata = () => {
     if (metadataIsShown) {

frontend/src/features/layersSelector/utils/MyLayerZone.tsx

@@ -29,7 +29,7 @@ type MyLayerZoneProps = {
   removeZone: () => void
   showLayer: () => void
   toggleZoneMetadata?: () => void
-  type: string | null
+  type: string | undefined
 }
 
 export function MyLayerZone({

frontend/src/utils/getDateAsLocalizedString.tsx

@@ -7,7 +7,7 @@ export function formatDateLabel(dateLabel: string) {
   )
 }
 
-export function getDateAsLocalizedStringExpanded(date: string | undefined | null) {
+export function getDateAsLocalizedStringExpanded(date: string | undefined) {
   if (!date || date.trim() === '') {
     return undefined
   }
@@ -20,7 +20,7 @@ export function getDateAsLocalizedStringExpanded(date: string | undefined | null
   )
 }
 
-export function getDateAsLocalizedStringCompact(date: string | undefined | null, withUtc = false) {
+export function getDateAsLocalizedStringCompact(date: string | undefined, withUtc = false) {
   if (!date || date.trim() === '') {
     return undefined
   }