Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #472 but still need some discussion #504

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

fix #472 but still need some discussion #504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion shapash/manipulation/summarize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,8 @@ def compute_corr(df, compute_method):
from phik import phik_matrix
return phik_matrix(df, verbose=False)
elif compute_method == 'pearson':
return df.corr()
# remove columns with constant values that lead to NaNs
return df.loc[:, (df != df.iloc[0]).any()].corr()
else:
raise NotImplementedError(f'Not implemented correlation method : {compute_method}')

Expand Down