feat: 스터디 생성 페이지 재작성, 구조 재정의 #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 스터디 기간은 제외함
SungHyun627
approved these changes
May 1, 2024
src/Components/Heading/index.tsx
Outdated
| return <H4 style={{ ...Property[component][type] }}>{children}</H4>; | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
Heading 컴포넌트가 깔끔하네요. 다른 페이지에도 적용시키는 과정 진행하겠습니다 👍.
There was a problem hiding this comment.
@SungHyun627 git blame 보시면 아시겠지만 클레어님이 제작하신 코드입니다
src/Components/Common/Grid/index.tsx
Outdated
There was a problem hiding this comment.
Grid까지 Common 컴포넌트화 하셨네요!! 세심함에 감탄하고 갑니다👍
There was a problem hiding this comment.
원본은 클레어님이 제작하신 코드입니다...
잘 보시면 Co-Authored-By: hyosin Jang <[email protected]> 가 있습니다.
There was a problem hiding this comment.
.tsx => .ts로 수정이 필요할 것 같습니다
There was a problem hiding this comment.
@SungHyun627
해당 스토리 파일 내에서 JSX 문법을 사용하기 때문에 .tsx 확장자를 사용했습니다. 아마 없으면 vite에서 별도의 JSX loader(= babel 컴파일러) 설정을 해줘야 하는 것으로 알고 있습니다.
혹시 .ts 확장자로도 무사히 작동하는 것을 로컬에서 테스트해주실 수 있을까요?
| @@ -0,0 +1,126 @@ | |||
| import { forwardRef, useMemo } from 'react'; | |||
| import Select, { ActionMeta, GroupBase, MultiValue, Props, SelectInstance, StylesConfig } from 'react-select'; | |||
There was a problem hiding this comment.
react-select에서 커스텀할 수 있는 옵션을 많이 제공해주네요👍
hyosin-Jang
reviewed
May 2, 2024
abiriadev
force-pushed
the
feat/create-study
branch
from
c2d7c9d to
1a2da7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(WIP)
💡 다음 이슈를 해결했어요.
#155
스터디 생성 페이지
스터디 수정 페이지
(가능한 한 자세히 작성해 주시면 도움이 됩니다.)
💡 이슈를 처리하면서 추가된 코드가 있어요.
SelectBox컴포넌트를 추가했어요.https://github.com/Ludo-SMP/ludo-frontend/blob/feat/create-study/src/Components/Selectbox/SelectBox.tsx
BoldDivider컴포넌트를 추가했어요.https://github.com/Ludo-SMP/ludo-frontend/blob/feat/create-study/src/Components/Common/Divider/BoldDivider/index.tsx
원본 피그마 문서: https://www.figma.com/file/OLgSF11mOFN5MpcYzpD3N3/Design-System?type=design&node-id=1607-1511&mode=design&t=lq46HiQMmXeedSw6-4
Stack컴포넌트를 추가했어요.https://github.com/Ludo-SMP/ludo-frontend/blob/feat/create-study/src/Components/Common/Stack/index.tsx
InputText컴포넌트의 로직을 재작성했어요.https://github.com/Ludo-SMP/ludo-frontend/blob/feat/create-study/src/Components/Common/InputText/iindex.tsx
atmos.ts파일을 생성했어요.https://github.com/Ludo-SMP/ludo-frontend/blob/feat/create-study/src/Types/atoms.ts
💡 필요한 후속작업이 있어요.
<option>요소에 들어갈 디자인 작성하고 스타일 적용하기<option>에 스타일을 적용할 방법 논의하기atoms.ts파일을 어디에 놓을 지 정하기.shared?utils?Shared에 무작위적으로 쌓인 폼 문구, 선택 옵션 등을 일관적으로 정리.💡 다음 자료를 참고하면 좋아요.
✅ 셀프 체크리스트