Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seungheonoh/ctlsubmodule #55

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Seungheonoh/ctlsubmodule #55

wants to merge 3 commits into from

Conversation

SeungheonOh
Copy link
Contributor

@SeungheonOh SeungheonOh requested a review from emiflake March 20, 2023 19:24
emiflake
emiflake reviewed Apr 6, 2023
View reviewed changes
Copy link
Member

@emiflake emiflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get the upstream PR merged first, but this looks good to me.

@emiflake emiflake force-pushed the seungheonoh/ctlsubmodule branch from 61bcee5 to 27130c6 Compare June 15, 2023 11:08
@emiflake emiflake force-pushed the seungheonoh/ctlsubmodule branch from 27130c6 to aa85cce Compare June 15, 2023 12:34
@emiflake
Copy link
Member

I rebased #67 into this PR. Hopefully we can get rid of this PR branch at some point, but this is still blocked by Plutonomicon/cardano-transaction-lib#1460.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emiflake emiflake emiflake left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SeungheonOh @emiflake