Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pin in hy_vfd to ease connection with Qtdragon GUI #2626

Merged
merged 16 commits into from
Oct 7, 2023

Conversation

looping40
Copy link
Contributor

In hy_vfd, error-count and retval are parameters and are not easily connectable to QtDragon GUI
I added pins to also publish those values.
Qtdragon also requires spindle speed in rps. It can be connected using a range adaptor but with the new spindle-speed-fb-rps it's straightforward

@c-morley
Copy link
Collaborator

c-morley commented Sep 4, 2023

Thank you for the pull request.
I have dug into this a little. It's a little bit of a wild west but...
It seems s32 pins for error count is common. I'm thinking maybe I should change Qtdragon to s32.
I still think adding the spindle RPS pin is a good idea.
I'll think on it some more.

@andypugh
Copy link
Collaborator

andypugh commented Sep 4, 2023

Anything that you can do with a parameter (setp, getp) can be done with a pin. So it is probably better to just switch the parameters to pins.

@looping40
Copy link
Contributor Author

I didn't want to break something using params.
But yes I can juste replace params with pins.

OK, just let me know for s32 pins on error count.

@andypugh
Copy link
Collaborator

andypugh commented Sep 4, 2023

There are quite a few params that have been changed to pins in various components over the years.
Just don't forget that a pin needs a pointer to a pointer, not just a pointer.

@c-morley
Copy link
Collaborator

c-morley commented Sep 5, 2023

qtdragon can now connect to U32 or S32.
So yes switching to pins and the spindle RPS pin would still be a good pull request.

@looping40
Copy link
Contributor Author

looping40 commented Sep 5, 2023

The new -u32 values are not take into account in the handlers.

May be can add the 2 values as only one should be connected

I have fixed the error sorry.

@looping40
Copy link
Contributor Author

looping40 commented Sep 7, 2023

@c-morley Can you please push qtdragon/hd: -fix spindle fault pins to actually work on master

@c-morley
Copy link
Collaborator

c-morley commented Sep 7, 2023

pushed qtdragon work to master.

@looping40
Copy link
Contributor Author

looping40 commented Sep 7, 2023

Thanks
@c-morley
Since 1 or 2 days, I have the following error : 'AttributeError: "VCPWindow' object has no attribute "dro_button_stack_a'
I don't think that it is related because I have the same error with a fresh sim.qtdragon_hd.qtdragon_hd_xyz/qtdragon_hd_xyza.ini
qtdragon_hd_handler.py.1513
self.w['dro_axis_{}'.format(num)].setProperty('Qjoint_number',index)
It seems there an extra Q

@c-morley
Copy link
Collaborator

Ok fixed that error.

@looping40
Copy link
Contributor Author

@c-morley To me everything seems to be OK now, ready for a review ;)

@c-morley
Copy link
Collaborator

ok .. I'm away working for a bit, if no one else does in the mean time I will when I'm back

@gmoccapy gmoccapy merged commit 33c2c6e into LinuxCNC:master Oct 7, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants