-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding pin in hy_vfd to ease connection with Qtdragon GUI #2626
Conversation
Thank you for the pull request. |
Anything that you can do with a parameter (setp, getp) can be done with a pin. So it is probably better to just switch the parameters to pins. |
I didn't want to break something using params. OK, just let me know for s32 pins on error count. |
There are quite a few params that have been changed to pins in various components over the years. |
qtdragon can now connect to U32 or S32. |
I have fixed the error sorry. |
@c-morley Can you please push qtdragon/hd: -fix spindle fault pins to actually work on master |
pushed qtdragon work to master. |
Thanks |
Ok fixed that error. |
@c-morley To me everything seems to be OK now, ready for a review ;) |
ok .. I'm away working for a bit, if no one else does in the mean time I will when I'm back |
In hy_vfd, error-count and retval are parameters and are not easily connectable to QtDragon GUI
I added pins to also publish those values.
Qtdragon also requires spindle speed in rps. It can be connected using a range adaptor but with the new spindle-speed-fb-rps it's straightforward