Skip to content

Commit

Permalink
Fix node-gyp building on MacOS
Browse files Browse the repository at this point in the history
  • Loading branch information
rubensworks committed Aug 29, 2024
1 parent fcb86bc commit 787bad6
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
9 changes: 4 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,11 @@ jobs:
test:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
os: [ubuntu-latest, macos-14]
node-version:
- 18.x
- 20.x
- 22.x
steps:
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
Expand All @@ -34,9 +33,9 @@ jobs:
**/node_modules
.rdf-test-suite-cache
.rdf-test-suite-ldf-cache
key: ${{ runner.os }}-test-modules-${{ hashFiles('**/package-lock.json') }}
key: ${{ runner.os }}-${{ runner.node-version }}-test-modules-${{ hashFiles('**/package-lock.json') }}
- name: Install dependencies
run: npm install
run: npm install --verbose
- name: Run tests
run: npm run test
- name: Run bin
Expand Down
4 changes: 3 additions & 1 deletion binding.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
],
"defines": [
"HAVE_CDS",
"_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION",
],
"cflags!": [ "-fno-rtti", "-fno-exceptions" ],
"cflags_cc!": [ "-fno-rtti", "-fno-exceptions" ],
Expand All @@ -46,7 +47,8 @@
"GCC_ENABLE_CPP_EXCEPTIONS": "YES",
"OTHER_CFLAGS": [
"-stdlib=libc++",
"-Wno-register"
"-Wno-register",
"-std=c++17",
],
},
},
Expand Down

0 comments on commit 787bad6

Please sign in to comment.