Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new constants folder #57

Merged
merged 1 commit into from
Nov 26, 2024
Merged

feat: new constants folder #57

merged 1 commit into from
Nov 26, 2024

Conversation

ChinmayShringi
Copy link

@ChinmayShringi ChinmayShringi commented Nov 25, 2024

Description

Fixes - Review and document constants in Lind-WASM
(#46)
(#30)

This PR reviews and updates the constants defined in the following files:

  • src/constants/mod.rs
  • src/constants/fs_constants.rs
  • src/constants/net_constants.rs
  • src/constants/sys_constants.rs

Key changes:

  1. Added comprehensive source references to Linux kernel v6.5 headers
  2. Added detailed documentation for each constant group
  3. Added explanatory comments for individual constants
  4. Identified platform-specific and Lind-specific constants
  5. Fixed type inconsistencies (u32/i32) where needed
  6. Organized constants into logical groups
  7. Added references to POSIX.1-2017 standard

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • cargo build

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have verified all constants against official Linux kernel sources
  • I have documented platform-specific considerations
  • I have identified and documented Lind-specific constants
  • I have cross-referenced constants with POSIX standards where applicable

@rennergade rennergade merged commit a19b268 into vmmap-alice Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants