Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #48
kernel close
The updated fdtable API passing fd entry and count instead of real fd into
kernel_close
function in RawPOSIX, which will cause the actual requested real fd not being closed. Updated code to fit newest API.select
The initial error occurred because cases where each
fd_set
was empty were not handled. In the updated code, uninitialized values are automatically assigned to the correspondingfd_set
. Additionally, during in-depth debugging, I found that when processing the return value, thefdtable::
function should receive annfd
associated with the kernel file descriptor (i.e., the maximum kernel file descriptor + 1).Type of change
How Has This Been Tested?
Checklist: