Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.2 support #75

Merged
merged 16 commits into from
Nov 29, 2024
Merged

8.2 support #75

merged 16 commits into from
Nov 29, 2024

Conversation

tacman
Copy link
Collaborator

@tacman tacman commented Oct 15, 2024

This mostly reorders the parameters, since 8.2 doesn't allow optional parameters before required ones.

@konradkozaczenko
Copy link

Hello @tacman, do you plan to merge this PR in the near future? Can you please consider supporting version 8.4? Maybe after merge it is a good time to create new release version?

@tacman tacman merged commit c364314 into Limenius:master Nov 29, 2024
5 checks passed
@tacman
Copy link
Collaborator Author

tacman commented Nov 29, 2024

yes, I'll do a new release which drops outdated versions.

@tacman
Copy link
Collaborator Author

tacman commented Nov 29, 2024

Can you please review the 2.0 release?

@konradkozaczenko
Copy link

Can you please review the 2.0 release?

looks good. I have already implemented this version in my project and everything works and the tests pass. Thanks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants