New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update config getters per ember-deploy#37. #1

Open

jamesfid wants to merge 1 commit into LevelbossMike:master from jamesfid:update-config-references

jamesfid commented Feb 24, 2015

Updated the adapter's configuration getters per the API change from ember-cli-deploy/ember-cli-deploy#3.


          Update config getters per ember-deploy#37.

54acd1f

Author

jamesfid commented Feb 24, 2015

How should the tests be approach with the new configuration API? A couple options that come to mind:

Stub a get method into the configuration for the tests.
Add a dependency for ember-deploy and require models/config to build the configuration object for the tests.

Let me know how you want this handled and I can update the tests accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet