-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit: How many components do not have storybook stories-new (#597) #622
base: develop
Are you sure you want to change the base?
Audit: How many components do not have storybook stories-new (#597) #622
Conversation
- [x] Added an mdx doc to identify components lacking comprehensive Storybook stories. Closes #597.
Gridiron Survivor Application
Project name: Gridiron Survivor Application
Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
||
### Components | ||
|
||
<table> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this table using mdx syntax. To find out more, please look at table mdx syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current syntax is valid MDX for the table and is much easier to maintain, as we will continually add components. This syntax also makes Tailwind available to add background colors and additional formatting easily.
Shashi already approved my current version, but I will revise it if he changes his mind.
<tr> | ||
<th>Component Name</th> | ||
<th>Sufficient Story</th> | ||
<th>Insufficient Story</th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are we using to consider a story insufficient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are components with previous Stories written that must meet Shashi's standards.
The 'Insufficient Storyfield' allows us to identify current and future Stories that must be rewritten to meet the required standards.
(Per Shashi, we will be following the carbon design system for GIS Story standards)
-Closes #597.