Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit: How many components do not have storybook stories-new (#597) #622

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

MichaelLarocca
Copy link

  • Added an mdx doc to identify components lacking comprehensive Storybook stories.

-Closes #597.

- [x] Added an mdx doc to identify components lacking comprehensive Storybook stories. Closes #597.
Copy link

appwrite bot commented Oct 25, 2024

Gridiron Survivor Application 6616ea581ef9f5521c7d

Function ID Status Action
Your function has been successfully deployed.

Project name: Gridiron Survivor Application
Project ID: 6616ea581ef9f5521c7d

Function ID Status Action
userAuth 6626fef885a9f630442b ready Ready View Logs

Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.

💡 Did you know?
Cursor pagination performs better than offset pagination when loading further pages

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gridiron-survivor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 9:01pm
gridiron-survivor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 9:01pm


### Components

<table>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this table using mdx syntax. To find out more, please look at table mdx syntax

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current syntax is valid MDX for the table and is much easier to maintain, as we will continually add components. This syntax also makes Tailwind available to add background colors and additional formatting easily.

Shashi already approved my current version, but I will revise it if he changes his mind.

<tr>
<th>Component Name</th>
<th>Sufficient Story</th>
<th>Insufficient Story</th>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are we using to consider a story insufficient?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are components with previous Stories written that must meet Shashi's standards.

The 'Insufficient Storyfield' allows us to identify current and future Stories that must be rewritten to meet the required standards.

(Per Shashi, we will be following the carbon design system for GIS Story standards)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit: How many components do not have storybook stories
3 participants