Leaves Plugin #271
Merged
Leaves Plugin #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lumine1909
reviewed
Jul 23, 2024
| + public ApiVersion deserialize(final Type type, final Object obj) throws SerializationException { | ||
| + try { | ||
| + final ApiVersion version = ApiVersion.getOrCreateVersion(obj.toString()); | ||
| + if (version.isOlderThan(MINIMUM)) { |
There was a problem hiding this comment.
这里应该支持过旧不支持过新 类似于bukkit api-version
There was a problem hiding this comment.
这里是仿照Paper逻辑的。
为了防止你把1.13的插件也标上leaves plugin tag
There was a problem hiding this comment.
这里是仿照Paper逻辑的。 为了防止你把1.13的插件也标上leaves plugin tag
那我们是否需要一个MAXIMUM version用来防止使用超版本的api
Lumine1909
pushed a commit
to Lumine1909/LeavesFork
that referenced
this pull request
Sep 15, 2024
* Create devcontainer.json * feat: leaves plugins base * Show leaves plugins in /plugins * Fix LeavesPluginMeta * Delete .devcontainer directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.