Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker use node 16 and udev, generic debian base. #104

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

easytarget
Copy link
Contributor

This updates the Dockerfile to support recent serialport changes and improve cross-platform support.

Changed the base image to the 'official' node16/bullseye image; this brings support for multiple platforms (armhf, arm64, i32, x64, ppc), and better supports node serialport + udev.

Added a DOCKER.md document to the repo detailing how to build+run with the correct nice setting.

@cprezzi
Copy link
Member

cprezzi commented Apr 6, 2022

@easytarget Do you want me to merge this PR? You should be able to merge it yourself.

@easytarget
Copy link
Contributor Author

easytarget commented Apr 6, 2022

@cprezzi It's not urgent, and I did want your feedback since I dont want to break anything that may rely on the docker build. I'm a bit concerned about if it is being used in the electron build.

Also; I dont seem to be able to merge this; not sure what is up there but I see 'Only those with write access to this repository can merge pull requests.` above; so I assume something went wrong there..

@cprezzi
Copy link
Member

cprezzi commented Apr 6, 2022

I saw that you never acepted my invitation to the LaserWeb devteam. Now I re-invited you to the LaserWeb devteam and core-devs. You need to accept the invitation ;)

@easytarget
Copy link
Contributor Author

Ok, I've got it now. I obviously missed the mail first time around. Thanks!

@cprezzi
Copy link
Member

cprezzi commented Nov 15, 2023

@easytarget Do you want to finaly merge this PR? The docker file is not used for the electron build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants