Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Vulkan mod #238

Closed
Danszerlied opened this issue Oct 5, 2024 · 1 comment
Closed

Incompatible with Vulkan mod #238

Danszerlied opened this issue Oct 5, 2024 · 1 comment
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@Danszerlied
Copy link

Describe the bug
Dynamic lights do not work with vulkan mod (visuals)

To Reproduce
Steps to reproduce the behavior:

  1. download vulkan mod
  2. download lambdynamiclights
  3. join world
  4. no dyn lighting

Desktop (please complete the following information):

  • OS: Windows
  • Minecraft [e.g. 1.16.4]
  • Fabric Loader version : 0.16.5
  • Mods : fabric api, vulkan and lambdynlights
  • Version 1.21

Additional context
not crash related

@Danszerlied Danszerlied added the bug Something isn't working label Oct 5, 2024
@LambdAurora LambdAurora added the wontfix This will not be worked on label Oct 28, 2024
@LambdAurora
Copy link
Owner

LambdAurora commented Oct 28, 2024

Terrain is indeed not lit up.

This is most likely due by Vulkan Mod not using LevelRenderer.getLightColor directly and instead re-implementing their own function. Update: not likely, basically confirmed, they're using Sodium's 0.5 lighting pipeline.

Honestly at this point, seeing Sodium and other similar rendering mods are well capable of using that method directly, which even allowed me to vastly reduce Sodium-specific code in latest versions of LambDynamicLights, I'm not going to add more fragile injection points into other rendering mods.

Please bring this up directly to Vulkan Mod developers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants