Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support for dynamic lighting #515

Closed
Danszerlied opened this issue Oct 5, 2024 · 5 comments
Closed

[Feature Request] Support for dynamic lighting #515

Danszerlied opened this issue Oct 5, 2024 · 5 comments

Comments

@Danszerlied
Copy link

Describe the request

It'd be very cool if Vulkan mod natively integrates dynamic handheld lighting, as no such mods are compatible with Vulkan mod atm (lambdynlights or ryoamiclights are incompatible)

@Felix14-v2
Copy link

These mods may get support after the 0.5.0 release. You can already find the testing build with FRAPI support in VulkanMod Discord.

@NXTler
Copy link
Contributor

NXTler commented Oct 27, 2024

Dynamic light will probably never be implemented into VulkanMod directly, as it can be easily done externally and would only decrease code readability. Lambdynlights and Ryoamiclights developers need to fix the compatibility issue from their side, as far as I know.

@NXTler
Copy link
Contributor

NXTler commented Oct 27, 2024

This can be closed.

@LambdAurora
Copy link

Dynamic light will probably never be implemented into VulkanMod directly, as it can be easily done externally and would only decrease code readability. Lambdynlights and Ryoamiclights developers need to fix the compatibility issue from their side, we can't do anything.

LambDynamicLights uses LevelRender.getLightColor(BlockAndTintGetter, BlockState, BlockPos) as its injection point, and with several versions of similar rendering mods not requiring specific compatibility code anymore, I personally would rather avoid adding yet more fragile injections in my own mod.

Relevant issue on LambDynamicLights' side: LambdAurora/LambDynamicLights#238.

@xCollateral
Copy link
Owner

Fixed by 349de86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants