project(dataverse): cambios dataset spec #1588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unjust
reviewed
Sep 22, 2023
| ``` | ||
|
|
||
| puede ser estructurada semánticamente en HTML como: | ||
|
|
||
| ```html | ||
| <dl itemscope itemtype="pokemon"> | ||
| <dl itemscope itemtype="WomeInTech"> |
There was a problem hiding this comment.
Suggested change
| <dl itemscope itemtype="WomeInTech"> | |
| <dl itemscope itemtype="WomenInTech"> |
| } | ||
| ``` | ||
|
|
||
| Los _nombres de las propiedades_, deben estar en formato _camelCase_. |
There was a problem hiding this comment.
Porque debe que ser camel case? creo si tienen _ o - no hay problema.
There was a problem hiding this comment.
Todo el json ya está en camelCase, por eso lo pus
| debe ser la siguiente: | ||
|
|
||
| * `id`: Identificador único (no pueden haber dos elementos con el mismo `id`). | ||
| Debe ser un string de no más de 64 characteres, en minúscula, compuesto solo |
There was a problem hiding this comment.
64 seria un poco largo en un url. Pero esta bien
unjust
changed the title
* feat(deps): Added Vite * config: removes duplicate key and adds (for now empty but mut be changed) process.env def * chore(deps): Updates @laboratoria/react/dist imports to @laboratoria/react/src as per last release * feat(workflow): Updates env variable examples and updates github ci/cd workflows with new variables - deprecates REACT_APP_ variables and the set-output task * chore(config): Updates vite config file and @laboratoria/react dependency * fix(lib): Undo changes to lib/data.js process.env * chore(deps): Removes react-scripts and webpack config file * fix(package.json): removes type module * fix(vite cofig): Adds dotenv() to vite.config file * chore(deps): Update dependencies and adds dotenv dep * fix(env/workers): Updates env variables and fixes workers/ symlink * fix(gh actions): Fixes Laboratoria api urls * fix(config): Fixes env variable name in Vite config file * chore(deps): Updates @laboratoria/react dependency with ace editor fixes * feat(vitest): Adds Vitest, jsdom, test setup in vite.config.js, moves __mocks__ to root dir and fixes components tests * chore(deps): Removes unused Jest config * fix(test): Fixes Topic test in node 20 * chore(docs): Actualiza todas las referencias antiguas del repo Laboratoria/bootcamp a Laboratoria/curriculum * chore(release): Bumps version to v7.0.0 and updates dist files * fix(project docs): Adds thumbnails to UX projects READMEs * fix(assets): Fixes outdated 01-design-and-usability thumbnail * feat(sentry): Adds Sentry config function from @laboratoria/react in src/index.jsx and adds the corresponding variable to github actions (Laboratoria#1554) * fix(yml): add titles and links for some oas typescript (Laboratoria#1556) * fix: add titles and links for some oas typescript * fix: oas typescript portuguese * space * Update learning-objectives/intl/es.yml * Convert Fleet Management Service Project from fullstack to backend (Laboratoria#1542) * Convert project from fullstack to backend * CLI specifications, poor performance by default, pagination * feat: Adds prompting learning objectives addresses Laboratoria#1510 (Laboratoria#1567) * adds prompting OAs and translation en es * portugues, corrections * Apply suggestions from code review Co-authored-by: Alfredo González <[email protected]> * simplify oas * few shot prompting * cambia titulos de recursos * quitar prompting oa de data lovers * Update learning-objectives/intl/es.yml Co-authored-by: David Ruiz <[email protected]> --------- Co-authored-by: Alfredo González <[email protected]> Co-authored-by: David Ruiz <[email protected]> * chore(release): Bumps version to v7.1.0 and updates dist files * fix: Reemplazar create react app, fixes Laboratoria#1453 (Laboratoria#1555) * falta imagen para reemplazar * imagen react * sin create-react-app, con imagen * con creacion de carpeta * mdlint * mdlint espacios en heading * sin coma * eliminar procedimiento * eliminar imagen * espacio debajo de los titulos * Update projects/04-notes/README.md Co-authored-by: Ivy Feraco <[email protected]> * descripción de linkk --------- Co-authored-by: Ivy Feraco <[email protected]> * fix: cambios con feedback DEV011 - resaltar root, modificar instrucciones Addresses Laboratoria#1577 (Laboratoria#1587) * resaltar root, modificar instruccion de view * cambio de instrucciones en dataFunctions, cambiar el console.log para ejecutar las funciones, añadir parametro en view.js * mejorar instrucciones en dataFunctions * espacios despues comments * Quita prototipo de baja, reordenar indice --------- Co-authored-by: Ivy Feraco <[email protected]> Co-authored-by: Ivy Feraco <[email protected]> * fix: remove extra docs in Dataverse and edit title (Laboratoria#1586) * remove EXTRA and old data lovers README in pt * move some resources to main README, delete FAQ * Apply suggestions from code review, acentos etc. Co-authored-by: David Ruiz <[email protected]> * Update README.md quita card class --------- Co-authored-by: David Ruiz <[email protected]> * fix: adds prompting objectives to project.yml (Laboratoria#1585) --------- Co-authored-by: Alfredo González <[email protected]> Co-authored-by: Alfredo González <[email protected]> Co-authored-by: Ivy Feraco <[email protected]> Co-authored-by: Sergio Sinuco <[email protected]> Co-authored-by: David Ruiz <[email protected]> Co-authored-by: ivy <[email protected]> Co-authored-by: DeysiVergara <[email protected]>
|
Si, los tests creo q ya están casi todos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1576