Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of distutils #127

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Remove usage of distutils #127

merged 1 commit into from
Nov 9, 2023

Conversation

chapman39
Copy link
Collaborator

@chapman39 chapman39 commented Nov 9, 2023 •
edited
Loading

distutils is deprecated with removal planned for Python 3.12

  • Printing full output of spack --version
  • Replace distutils.dir_util.copy_tree with shutil.copytree (Someone should test this on Windows though, since I'm on Mac)

Fixes #99

@chapman39 chapman39 self-assigned this Nov 9, 2023
chapman39
chapman39 commented Nov 9, 2023
View reviewed changes
uberenv.py
@@ -59,12 +59,10 @@
import socket
import platform
import json
import datetime
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed datetime as well as it's not being used

white238
white238 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@white238 white238 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

kennyweiss
kennyweiss approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@kennyweiss kennyweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chapman39 !

@chapman39 chapman39 merged commit 0a39ce2 into main Nov 9, 2023
8 checks passed
@chapman39 chapman39 deleted the task/chapman39/replace_distutils branch November 9, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyweiss kennyweiss kennyweiss approved these changes

@cyrush cyrush cyrush approved these changes

@white238 white238 white238 approved these changes

Assignees

@chapman39 chapman39

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

distutils.version Depreceation Warning
4 participants
@chapman39 @white238 @cyrush @kennyweiss