Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix libROM CI Failure on MacOS 12 #175

Open
wants to merge 52 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
76281cb
Install gfortran Mac dependency
Dec 6, 2022
25f72f6
Install gcc10
Dec 6, 2022
5ebf47a
brew install gcc
Dec 6, 2022
aefb23d
Change gfortran version
Dec 6, 2022
6de9fff
libquadmath issue on MacOS 12
Dec 6, 2022
2f8da77
Test
Dec 6, 2022
48460e4
Test
Dec 6, 2022
83629bb
Test
Dec 6, 2022
2835cf2
Test
Dec 6, 2022
668027c
rpath test
Dec 7, 2022
b07aaba
Commit
Dec 7, 2022
1a39c0a
Symlink libquadmath.dylib
Dec 7, 2022
2c99685
Commit
Dec 7, 2022
2c93d4c
Test
Dec 7, 2022
e2932dd
Test
Dec 7, 2022
dd56f58
Test
Dec 7, 2022
39d82ed
Test
Dec 7, 2022
0e7bcc0
Test
Dec 7, 2022
f6abc1d
Test
Dec 7, 2022
e5d5015
Look for rpath of libquadmath
Dec 7, 2022
896a826
Merge branch 'master' of https://github.com/LLNL/libROM into mac_ci_orig
Jan 3, 2023
e0dd699
Print libquadmath LC_RPATH on MacOS 12
Jan 3, 2023
8efed39
otool: Specify full path to libquadmath
Jan 4, 2023
27eb870
Change libquadmath rpath
Jan 4, 2023
9e44872
small fix
Jan 4, 2023
20efd77
Absolute path
Jan 4, 2023
20c0201
Specify LD_LIBRARY_PATH
Jan 4, 2023
f1e1525
Add rpath
Jan 4, 2023
2d4d402
small fix
Jan 4, 2023
988bea3
Minor change
Jan 4, 2023
cdd4adb
executable path
Jan 4, 2023
8c9f48d
Small fix
Jan 4, 2023
50c8829
Test
Jan 4, 2023
dbc23c7
rpath test
Jan 4, 2023
405721f
Minor fix
Jan 4, 2023
e096f8a
More debugging output
Jan 5, 2023
b3228c0
Small fix
Jan 5, 2023
486a9ec
Isolate otool output field after rpath addition: LC_RPATH
Jan 6, 2023
0022f71
Remove default rpath
Jan 6, 2023
b0a914d
Restore rpath change
Jan 6, 2023
39bf75d
Small fix
Jan 6, 2023
62a8ee2
Small fix
Jan 6, 2023
9523001
apt-update
Jan 6, 2023
58bc294
Delete LC_RPATH
Jan 7, 2023
395265b
Specify @loader_path
Jan 7, 2023
9dc3774
List /usr/local/lib/gcc/12/ contents and attempt rpath change command
Jan 8, 2023
65c6007
Restore delete/add rpath
Jan 8, 2023
ce4ac03
Small fix
Jan 9, 2023
9c500fd
Add GITHUB_WORKSPACE to rpath
Jan 9, 2023
5686ac1
Check architecture
Jan 9, 2023
9289ab3
Small fix
Jan 9, 2023
a133a1c
Remove inapplicable comment
Jan 10, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ jobs:

- name: Install Linux dependencies
run: |
sudo apt update
sudo apt-get install libmpich-dev libblas-dev liblapack-dev libscalapack-mpi-dev libhdf5-serial-dev
- name: Check out libROM
uses: actions/checkout@v2
Expand Down Expand Up @@ -51,6 +52,16 @@ jobs:
steps:
- name: Install Mac dependencies
run: |
uname -a
gcc --version
echo "Listing contents of /usr/local/lib/gcc/12"
ls /usr/local/lib/gcc/12
cd /usr/local/lib/gcc/12
echo "Architecture that libquadmath.0.dylib is compiled for: "
file /usr/local/lib/gcc/12/libquadmath.0.dylib
otool -l /usr/local/lib/gcc/12/libquadmath.0.dylib | grep -A2 LC_RPATH
mkdir -p ${GITHUB_WORKSPACE}/build/lib
cp /usr/local/lib/gcc/12/libquadmath.0.dylib ${GITHUB_WORKSPACE}/build/lib
brew install open-mpi
brew install openblas
brew install lapack
Expand All @@ -61,11 +72,11 @@ jobs:
- uses: ./.github/workflows/checkout_repo
- name: Build libROM
run: |
export FC=/usr/local/bin/gfortran-10
mkdir ${GITHUB_WORKSPACE}/build
export FC=/usr/local/bin/gfortran-12
mkdir -p ${GITHUB_WORKSPACE}/build
cd ${GITHUB_WORKSPACE}/build
cmake -DCMAKE_BUILD_TYPE=Debug ..
make
cmake -DCMAKE_BUILD_TYPE=Optimized ..
cmake -DCMAKE_BUILD_TYPE=Optimized ..
make
- uses: ./.github/workflows/run_tests