Cnn #210
Merged
Cnn #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x this to simply chop off static NL if matching module at the end
…. Fixed bug in TF nmse calc. Made per_cell=True default. Added a bunch of TF options to init.tf
…he registry lib. Maybe this should be kept in a separate lib?
arrrobase
approved these changes
Mar 26, 2020
There was a problem hiding this comment.
Looks good to me. This is somewhat similar to a module/plugin implementation I had been working on a while back as a long term project: https://github.com/awctomlinson/ModuleRegistry
|
@awctomlinson Thanks. Yeah, this does look very similar. I think the keywords can still be embedded in an object (like you did). Only difference as it is now is that the decorators assume that the function name is the keyword name. ... I guess the question is if it's helpful to have a generic "keyword" method and make the keyword a parameter or if my system will work. Well, we can always make it support either, just by adding an option to nems.registry.xform to pass the keyword name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dumb branch name, actually dealing with #171 to work on keyword simplification.
new configuration setting LIB_PLUGINS. When you import nems, init.py creates registries (xforms_lib and keyword_lib) it will then import modules listed in LIB_PLUGINS. any function with the decorator xform or xmodule will be imported into the appropriate registry. xforms then uses these existing registries rather than creating new ones when you fit a model. I don't see why it's a problem--unless you want to have two sets of registries around(?)
to test, you can get the new nems_db master and add
LIB_PLUGINS = ['nems_lbhb.columbia_helpers']to nems.configs.settings