Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percussion-related notes should always use fixed pitches in AddmusicM songs #442

Open
KungFuFurby opened this issue Jul 29, 2024 · 0 comments
Labels
addmusicm Involves an adaptation that originates from AddMusicM. bug Something isn't working c++-side Involves the AddMusicK program itself in some way.

Comments

@KungFuFurby
Copy link
Owner

This is an error that was accidentally discovered during an analysis of a song that had been constantly remoderated over the years, though the song's origins predate Addmusic405 and AddmusicM. It is a partial regression of #198 for AddmusicM songs only... but it applies to all channels.

It just so happens that a percussion note is constantly output while the instrument is set to @21-@30. This behavior applies to all channels in the AddmusicM adaptation, but not the Addmusic405 adaptation.

This also applies to Addmusic Java and carol's Addmusic.

@KungFuFurby KungFuFurby added bug Something isn't working c++-side Involves the AddMusicK program itself in some way. addmusicm Involves an adaptation that originates from AddMusicM. labels Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addmusicm Involves an adaptation that originates from AddMusicM. bug Something isn't working c++-side Involves the AddMusicK program itself in some way.
Projects
None yet
Development

No branches or pull requests

1 participant