Fix make bundle #998
Merged
Fix make bundle #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
eguzki
force-pushed
the
fix-make-bundle
branch
from
0f8842e to
5c45eff
Compare
|
I summon our bash expert for review @mikenairn |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #998 +/- ##
==========================================
+ Coverage 76.15% 83.82% +7.66%
==========================================
Files 111 81 -30
Lines 8986 6632 -2354
==========================================
- Hits 6843 5559 -1284
+ Misses 1852 860 -992
+ Partials 291 213 -78
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
eguzki
force-pushed
the
fix-make-bundle
branch
from
743658f to
e57e427
Compare
mikenairn
approved these changes
Nov 11, 2024
maleck13
pushed a commit
that referenced
this pull request
Nov 13, 2024
* fix make bundle Signed-off-by: Eguzki Astiz Lezaun <[email protected]> * doc/development.md: little fix Signed-off-by: Eguzki Astiz Lezaun <[email protected]> --------- Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
bundlemakefile phony target does not fail when a referenced bundle image does not existThis fix makes it fail fast when bundle image does not exist on.
For example, with the changes of this branch, running
The resulting error is:
And the command returns early with the error.
On the other hand, without the changes of this PR (checkout on
mainbranch), running the command:The command still fails, but the error is a bundle validation step
Just because the generated bundle is not correct (due to missing bundle image)