Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

point at latest healthcheck spec #947

Merged
merged 1 commit into from
Oct 18, 2024
Merged

point at latest healthcheck spec #947

merged 1 commit into from
Oct 18, 2024

Conversation

maksymvavilov
Copy link
Contributor

No description provided.

Signed-off-by: Maskym Vavilov <[email protected]>
@maksymvavilov maksymvavilov force-pushed the point-at-latest-dns-spec branch from 93601fa to da5f2a0 Compare October 18, 2024 15:15
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.13%. Comparing base (63f1d28) to head (da5f2a0).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #947      +/-   ##
==========================================
- Coverage   81.49%   80.13%   -1.37%     
==========================================
  Files         102      117      +15     
  Lines        7177     9523    +2346     
==========================================
+ Hits         5849     7631    +1782     
- Misses        898     1460     +562     
- Partials      430      432       +2     
Flag Coverage Δ
bare-k8s-integration 9.20% <ø> (+0.30%) ⬆️
controllers-integration 70.57% <ø> (+5.25%) ⬆️
envoygateway-integration 48.01% <ø> (-2.29%) ⬇️
gatewayapi-integration 13.33% <ø> (-1.08%) ⬇️
istio-integration 50.46% <ø> (-3.06%) ⬇️
unit 30.18% <ø> (+1.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 90.00% <ø> (-0.91%) ⬇️
api/v1beta2 (u) 86.18% <ø> (-0.43%) ⬇️
pkg/common (u) 86.48% <ø> (-1.65%) ⬇️
pkg/istio (u) 65.56% <100.00%> (-5.95%) ⬇️
pkg/log (u) 93.18% <ø> (-1.56%) ⬇️
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 83.93% <ø> (-1.91%) ⬇️
controllers (i) 81.80% <81.00%> (-1.26%) ⬇️

see 90 files with indirect coverage changes

Copy link
Collaborator

@maleck13 maleck13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@maleck13 maleck13 merged commit 8d7b92c into main Oct 18, 2024
32 checks passed
@maksymvavilov maksymvavilov deleted the point-at-latest-dns-spec branch October 18, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants