Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

final couple of tweaks kustomize install #1043

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

maleck13
Copy link
Collaborator

Signed-off-by: craig [email protected]

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED

Signed-off-by: craig <[email protected]>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.03%. Comparing base (cc1b41f) to head (860b760).
Report is 50 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1043      +/-   ##
==========================================
+ Coverage   76.15%   84.03%   +7.87%     
==========================================
  Files         111       81      -30     
  Lines        8986     6694    -2292     
==========================================
- Hits         6843     5625    -1218     
+ Misses       1852      856     -996     
+ Partials      291      213      -78     
Flag Coverage Δ
bare-k8s-integration 15.71% <ø> (+4.84%) ⬆️
controllers-integration 76.34% <ø> (+17.47%) ⬆️
envoygateway-integration 41.00% <ø> (+8.50%) ⬆️
gatewayapi-integration 16.09% <ø> (+2.65%) ⬆️
istio-integration 43.62% <ø> (+9.29%) ⬆️
unit 18.12% <ø> (-7.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 90.00% <100.00%> (-2.19%) ⬇️
api/v1beta2 (u) ∅ <ø> (∅)
pkg/common (u) ∅ <ø> (∅)
pkg/istio (u) 62.06% <ø> (+15.03%) ⬆️
pkg/log (u) 93.18% <ø> (ø)
pkg/reconcilers (u) 24.67% <ø> (∅)
pkg/rlptools (u) ∅ <ø> (∅)
controllers (i) 86.80% <90.34%> (+2.37%) ⬆️

see 39 files with indirect coverage changes

---- 🚨 Try these New Features:

@maleck13 maleck13 changed the title final couple of tweaks final couple of tweaks kustomize install Nov 21, 2024
@maleck13
Copy link
Collaborator Author

@eguzki made couple more small changes and added the catalog image to our olm/catalogsource.yaml when we do a release

Copy link
Contributor

@eguzki eguzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

this config/deploy/olm/kustomization.yaml is only being used here and it is already doing that.

so, if you check out the tagged version, and then, from Deploy kuadrant operator using OLM. you execute make deploy-catalog (without overriding CATALOG_IMG), the system would pick the tagged one and deploy the right version.

Anyway, this is harmless

@maleck13 maleck13 merged commit ce778a2 into main Nov 21, 2024
34 of 35 checks passed
@eguzki eguzki deleted the tweak-install-version branch November 21, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants