FIX: Context being cancelled and better Policy status #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boomatang
force-pushed
the
issue/1004
branch
from
7e68b8c to
1aff0b2
Compare
KevFan
reviewed
Nov 13, 2024
Comment on lines
115
to
+119
| func (r *RateLimitPolicyStatusUpdater) enforcedCondition(policy *kuadrantv1.RateLimitPolicy, topology *machinery.Topology, state *sync.Map) *metav1.Condition { | ||
| kObj := GetKuadrantFromTopology(topology) | ||
| if kObj == nil { | ||
| return kuadrant.EnforcedCondition(policy, kuadrant.NewErrSystemResource("kuadrant"), false) | ||
| } |
There was a problem hiding this comment.
Should this also be done for AuthPolicy ? The current condition for AuthPolicy without Kuadrant installed is:
status:
conditions:
- lastTransitionTime: "2024-11-13T08:50:35Z"
message: AuthPolicy has been accepted
reason: Accepted
status: "True"
type: Accepted
- lastTransitionTime: "2024-11-13T08:50:54Z"
message: 'AuthPolicy has encountered some issues: missing auth effective policies
stored in the reconciliation state'
reason: Unknown
status: "False"
type: EnforcedThere was a problem hiding this comment.
Yes this should have being done.
eguzki
reviewed
Nov 13, 2024
| @@ -40,9 +40,9 @@ var ( | |||
| ) | |||
|
|
|||
| func GetLimitadorFromTopology(topology *machinery.Topology) (*limitadorv1alpha1.Limitador, error) { | |||
There was a problem hiding this comment.
nit: what about returning only *limitadorv1alpha1.Limitador ?
I do not consider as an error when (kuadrant managed) limitador does not exist. It is a state or reality, not an error.
The GetKuadrantFromTopology was somehow cancelling the context of functions that called it. This improves the policy status of ratelimit policies when there is no kuadrant CR on cluster, or it was removed. Signed-off-by: Jim Fitzpatrick <[email protected]>
Add changes based on PR comments Signed-off-by: Jim Fitzpatrick <[email protected]>
Boomatang
force-pushed
the
issue/1004
branch
from
f6e4f62 to
59d4df1
Compare
KevFan
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GetKuadrantFromTopology was somehow cancelling the context of functions that called it.
This improves the policy status of ratelimit policies when there is no kuadrant CR on cluster, or it was removed.
Closes: #1004
Closes: #1011
Reproduce error
Install kuadrant from main.
Create the a working ratelimit example. RateLimitPolicy for Platform Engineers
Delete the kuadrant CR. Then check the state of the wasm plugin. It would be expected that this would be removed. However it will not. Restarting the kuadrant deployment will fix the issue and clean the resources up. Also the status in the ratelimiting policy will say it is still accepted.
Install the operator from this branch and get the cluster back into the state before the deletion of the kuadrant CR. This time when the Kuadrant CR is remove the wasm plugin will be removed and the enforced status will be false.