Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪛 add permissions to update gateway finalizer #1008

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Nov 12, 2024

No description provided.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.91%. Comparing base (cc1b41f) to head (2dfa878).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1008      +/-   ##
==========================================
+ Coverage   76.15%   83.91%   +7.76%     
==========================================
  Files         111       81      -30     
  Lines        8986     6628    -2358     
==========================================
- Hits         6843     5562    -1281     
+ Misses       1852      855     -997     
+ Partials      291      211      -80     
Flag Coverage Δ
bare-k8s-integration 15.93% <ø> (+5.06%) ⬆️
controllers-integration 76.22% <ø> (+17.36%) ⬆️
envoygateway-integration 40.58% <ø> (+8.07%) ⬆️
gatewayapi-integration 16.36% <ø> (+2.92%) ⬆️
istio-integration 43.57% <ø> (+9.24%) ⬆️
unit 17.04% <ø> (-8.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 90.00% <100.00%> (-2.19%) ⬇️
api/v1beta2 (u) ∅ <ø> (∅)
pkg/common (u) ∅ <ø> (∅)
pkg/istio (u) 62.06% <ø> (+15.03%) ⬆️
pkg/log (u) 93.18% <ø> (ø)
pkg/reconcilers (u) 24.67% <ø> (∅)
pkg/rlptools (u) ∅ <ø> (∅)
controllers (i) 86.79% <91.76%> (+2.36%) ⬆️
Files with missing lines Coverage Δ
controllers/state_of_the_world.go 92.19% <ø> (+0.02%) ⬆️

... and 23 files with indirect coverage changes

Copy link
Contributor

@guicassolato guicassolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@eguzki eguzki marked this pull request as ready for review November 12, 2024 13:07
@eguzki eguzki merged commit 5d97f9a into main Nov 12, 2024
35 checks passed
@eguzki eguzki deleted the gateway-finalizer branch November 12, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants