Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect kuadrant status if limitador/authorino is not found #1000

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

KevFan
Copy link
Contributor

@KevFan KevFan commented Nov 11, 2024

Description

  • fix: incorrect kuadrant status if limitador/authorino is not found
    • Kuadrant status would incorrectly report as Ready if limitador or authorino was not found within the topology
  • test: kuadrant status on bare k8s
    • Kuadrant status test on bare k8s was incorrect and should report GatewayAPIProviderNotFound instead

Verification

  • Passing integration tests should be enough

Otherwise to manually verify:

  • watch Kuadrant CR
watch -n 0.5 "kubectl get kuadrant -A -o yaml"
  • Deploy Kuadrant CR
kubectl -n kuadrant-system apply -f - <<EOF                                 
apiVersion: kuadrant.io/v1beta1
kind: Kuadrant
metadata:
  name: kuadrant
spec: {}
EOF
  • Verify Kuadrant CR status eventually becomes ready as Limitador or Authorino recomes ready

@KevFan KevFan self-assigned this Nov 11, 2024
@KevFan KevFan added kind/bug Something isn't working size/small labels Nov 11, 2024
@KevFan KevFan requested a review from Boomatang November 11, 2024 12:30
Copy link
Contributor

@Boomatang Boomatang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Its hard to see the error for when the resources are not in the topology.

@KevFan KevFan merged commit ccd1a97 into Kuadrant:main Nov 12, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants