sotw: auth #2530
guicassolatocode-style.yaml
on: pull_request
Lint
1m 47s
Matrix: Auto-format and Check
Annotations
13 errors and 8 warnings
|
Lint:
controllers/authconfigs_reconciler.go#L70
Consider pre-allocating `modifiedAuthConfigs` (prealloc)
|
|
Lint:
api/v1beta3/authpolicy_types.go#L133
var-naming: range var ruleId should be ruleID (revive)
|
|
Lint:
api/v1beta3/authpolicy_types.go#L138
var-naming: range var ruleId should be ruleID (revive)
|
|
Lint:
api/v1beta3/authpolicy_types.go#L147
var-naming: range var ruleId should be ruleID (revive)
|
|
Lint:
api/v1beta3/authpolicy_types.go#L259
var-naming: var ruleId should be ruleID (revive)
|
|
Lint:
api/v1beta3/authpolicy_types.go#L325
receiver-naming: receiver name ap should be consistent with previous receiver name p for AuthPolicy (revive)
|
|
Lint:
api/v1beta3/authpolicy_types.go#L330
receiver-naming: receiver name ap should be consistent with previous receiver name p for AuthPolicy (revive)
|
|
Lint:
controllers/auth_workflow_helpers.go#L109
unnecessary conversion (unconvert)
|
|
Lint:
controllers/auth_workflow_helpers.go#L111
unnecessary conversion (unconvert)
|
|
Lint:
controllers/authconfigs_reconciler.go#L154
(*AuthConfigsReconciler).buildDesiredAuthConfig - result 1 (error) is always nil (unparam)
|
|
Lint:
api/v1beta3/ratelimitpolicy_types.go#L287
"orignally" is a misspelling of "originally"
|
|
Lint:
api/v1beta3/authpolicy_types.go#L353
"overriden" is a misspelling of "overridden"
|
|
Lint
Process completed with exit code 1.
|
|
Auto-format and Check (gofmt)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v4, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Auto-format and Check (gofmt)
Restore cache failed: Dependencies file is not found in /home/runner/work/kuadrant-operator/kuadrant-operator. Supported file pattern: go.sum
|
|
Auto-format and Check (goimports)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v4, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Auto-format and Check (goimports)
Restore cache failed: Dependencies file is not found in /home/runner/work/kuadrant-operator/kuadrant-operator. Supported file pattern: go.sum
|
|
Lint
The following actions uses node12 which is deprecated and will be forced to run on node16: andstor/file-existence-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v4, actions/checkout@v3, andstor/file-existence-action@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/kuadrant-operator/kuadrant-operator. Supported file pattern: go.sum
|
|
Lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|