resolve fixmes

KomodoPlatform · Oct 6, 2024 · 868ee2c · 868ee2c
1 parent 91d98ed
commit 868ee2c
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 8 deletions.
diff --git a/mm2src/mm2_main/src/rpc/streaming_activations/balance.rs b/mm2src/mm2_main/src/rpc/streaming_activations/balance.rs
@@ -80,7 +80,6 @@ pub async fn enable_balance(
             let streamer = TendermintBalanceEventStreamer::new(coin.clone());
             ctx.event_stream_manager.add(client_id, streamer, coin.spawner()).await
         },
-        // FIXME: What about tokens?!
         _ => Err(BalanceStreamingRequestError::CoinNotSupported)?,
     };
 

diff --git a/mm2src/mm2_main/src/rpc/streaming_activations/mod.rs b/mm2src/mm2_main/src/rpc/streaming_activations/mod.rs
@@ -32,7 +32,7 @@ pub struct EnableStreamingRequest<T> {
 /// The success/ok response for any event streaming activation request.
 pub struct EnableStreamingResponse {
     pub streamer_id: String,
-    // FIXME: If the the streamer was already running, it is probably running with different configuration.
+    // TODO: If the the streamer was already running, it is probably running with different configuration.
     // We might want to inform the client that the configuration they asked for wasn't applied and return
     // the active configuration instead?
     // pub config: Json,

diff --git a/mm2src/mm2_main/src/rpc/streaming_activations/tx_history.rs b/mm2src/mm2_main/src/rpc/streaming_activations/tx_history.rs
@@ -67,7 +67,6 @@ pub async fn enable_tx_history(
             let streamer = ZCoinTxHistoryEventStreamer::new(coin.clone());
             ctx.event_stream_manager.add(client_id, streamer, coin.spawner()).await
         },
-        // FIXME: What about tokens?!
         _ => Err(TxHistoryStreamingRequestError::CoinNotSupported)?,
     };
 

diff --git a/mm2src/mm2_net/src/event_streaming/sse_handler.rs b/mm2src/mm2_net/src/event_streaming/sse_handler.rs
@@ -30,11 +30,7 @@ pub async fn handle_sse(request: Request<Body>, ctx_h: u32) -> Result<Response<B
 
     let event_stream_manager = ctx.event_stream_manager.clone();
     let Ok(mut rx) = event_stream_manager.new_client(client_id) else {
-        // FIXME: Such an error means that one client generated an id that is already in use
-        // by another (or it might be the same client all along). This is dangerous since
-        // that client now knows this id is in use and can open up and shut down streamers
-        // on the original id owner's behalf.
-        return handle_internal_error(format!("Bad id")).await
+        return handle_internal_error(format!("ID already in use")).await
     };
     let body = Body::wrap_stream(async_stream::stream! {
         while let Some(event) = rx.recv().await {