Perfomance: allow to set the onUpdateUI timeout using a hidden pref (…

[Defman21]

…onUpdateUI_timeout); fixed #2470

Signed-off-by: Defman21 [email protected]

[Naatan]

This would invoke getLong across xpcom every time updateUI is called, which is bad for performance. If we are to make a pref for this the pref needs to be stored (cached) and updated as needed (via pref observers).

[Defman21]

I'll look into that.

[Defman21]

Now ko/prefs is being called only once per buffer opening to get the pref value (i don't know how to call an observer immediately to set the initial value) . Each buffer has its own pref observer to update the onUpdateUI_timeout attribute.

[Defman21]

I'll do a fixup/rebase once you'll review my changes :)
One require call per buffer opening is not a big deal imo (<view>.prefs will return it without requiring again though)

[Naatan]

This is only creating the observer and not removing it. Which could lead to lingering observers and a minor memory leak. But seeing this I'm kind of second guessing whether to use an observer at all. I don't like the idea of having an observer for each buffer, but there is no better solution that I can see.

Given that this is a hidden pref I think we should just remove the observer part altogether. If someone wants to change this pref they'll have to restart Komodo or reopen their buffers. This pref will never be exposed in the UI.

[Defman21]

I agree.