Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-introduce shutdown fix and bump to async-http-client 1.2.0 #90

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dannys42
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ dannys42
❌ Danny Sung


Danny Sung seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dannys42 dannys42 requested a review from mbarnach February 11, 2021 14:57
@dannys42
Copy link
Contributor Author

@mbarnach There was some issue when you introduced this last time where other packages weren't compiling/running correctly. I don't remember why. But I'm reintroducing this and will tag it as a separate version so hopefully we'll be able to control it with versioning until the underlying issue is fixed.

Copy link
Member

@mbarnach mbarnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dannys42
Copy link
Contributor Author

@mbarnach there's weird compile issues and docker rate limiting... This might take me a while.

Danny Sung and others added 2 commits February 16, 2021 17:55
… org

- Update CircuitBreaker dependency to version pointing to Kitura org
- Add some debug printsin TestServer
- Tweak unit test testCircuitBreakFailure()
- RestRequest now attempts to shutdown immediately after request and
  before completion handler
- Disable test: testEventLoopGroup; it may(?) not still be relevant
@dannys42 dannys42 closed this Jul 3, 2022
@dannys42 dannys42 reopened this Jul 3, 2022
@dannys42 dannys42 closed this Jul 3, 2022
@dannys42 dannys42 reopened this Jul 3, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants