Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse UInt8/Int to Bool if expected type is Bool, Convenience Query function #111

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

123FLO321
Copy link

  • Parse UInt8/Int to Bool if expected type is Bool but got UInt8/Int
  • Convenience Query call using Database class

@CLAassistant
Copy link

CLAassistant commented Jun 9, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ianpartridge ianpartridge requested a review from kilnerm June 19, 2019 08:36
@ianpartridge ianpartridge added this to the 2019.13 milestone Jun 19, 2019
Copy link
Contributor

@kilnerm kilnerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@123FLO321 Would you mind splitting these changes out into the individual fixes you mentioned above please? It's better if we can keep merges unique to individual issues.

Thanks

@ianpartridge ianpartridge modified the milestones: 2019.13, 2019.14 Jul 3, 2019
@kilnerm kilnerm modified the milestones: 2019.14, 2019.15 Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants