Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing optimizations #85

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Parsing optimizations #85

wants to merge 6 commits into from

Conversation

scuml
Copy link
Contributor

@scuml scuml commented Oct 14, 2020

Performance and memory optimizations for parsing Redis responses.

Copy link

@futurejones futurejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that editing the travis.yml file is beyond the scope of this PR. There is no reason is given for the need to remove just linux, xenial, swift:4.0.3 from the Travis build tests.

IMO decisions on the removal of items from the Travis build matrix should be taken at the administration level and applied uniformly across all the Kitura repos.

Copy link
Member

@mbarnach mbarnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resumitting.
Here are my comments.

Sources/SwiftRedis/RedisResp.swift Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@scuml scuml requested a review from mbarnach November 16, 2022 13:16
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ scuml
❌ Stephen Mitchell


Stephen Mitchell seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants