Fix: Test PVRTC extension and always use power-of-two dimensions for PVRTC1 #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for your submission, we are reviewing it. |
lordalcol
requested changes
Mar 5, 2024
lordalcol
requested changes
Mar 5, 2024
external/vulkancts/modules/vulkan/api/vktApiMemoryRequirementInvarianceTests.cpp
Outdated
Show resolved
Hide resolved
lordalcol
reviewed
Mar 5, 2024
| @@ -264,7 +264,7 @@ DE_INLINE deUint32 deSmallestGreaterOrEquallPowerOfTwoU32 (deUint32 a) | |||
| } | |||
|
|
|||
| /*--------------------------------------------------------------------*//*! | |||
| * \brief Roud a value up to a power-of-two. | |||
| * \brief Round a value up to a power-of-two. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CTS tests always use random image sizes for testing images, which was not valid for PVRTC1 textures. With 1.3.279 a VUID was added to require power-of-two dimensions for PVRTC1 textures, as discussed in KhronosGroup/Vulkan-Docs#1991.
Also, this fixes a bug introduced with 4c7e4e9, as it required the extension to be present for the PVRTC formats to be tested, but it was never added as a extension to be enabled, so PVRTC textures were never tested.