-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update error message for aphrodite-add-style-variable-name rule (#1096)
## Summary: Updating the error message so it is more useful (noticed this after testing with the demo project) Previously: `Variable name "div" does not match tag name "div". Variable name should be "StyledDiv"` <img width="1203" alt="Screenshot 2024-12-13 at 2 26 27 PM" src="https://github.com/user-attachments/assets/1d3fd862-461f-4afd-b4bf-10c4ae7368be" /> New: `Variable name "div" does not match the expected naming convention. Expected: "StyledDiv"` Issue: FEI-5952 ## Test plan: - Tests continue to pass - Will integrate with the demo project once this update is released! Author: beaesguerra Reviewers: kevinb-khan Required Reviewers: Approved By: kevinb-khan Checks: ✅ Test (macos-latest, 20.x), ✅ CodeQL, ✅ gerald, ✅ Lint, typecheck, and coverage check (ubuntu-latest, 20.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ Analyze (javascript), ✅ gerald, ⏭️ dependabot Pull Request URL: #1096
- Loading branch information
1 parent
8f4b545
commit afc8d77
Showing
3 changed files
with
6 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@khanacademy/eslint-plugin": patch | ||
--- | ||
|
||
Update error message for `aphrodite-add-style-variable-name` rule |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters